Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): nesting npm lock file deps should support multi nests #14949

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

meeroslav
Copy link
Contributor

Imagine the following situation:

A@v1 -> D@v2 -> B@v2
B@v1
C@v1 -> B@v2
D@v1

Package B@v2 will have two nests - one as a direct child of C and another one as a child of A (since A has no B child of its own). Current implementation explicitly checks that there is only a single slot to place B@v2 causing this package to never be nested.

We need to support multiple nesting slots.

Current Behavior

If the package version has multiple nesting places, the stringifier ends up in the loop

Expected Behavior

Npm stringifier should support multiple nesting slots for the same package

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Feb 13, 2023
@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 9:41AM (UTC)

@FrozenPandaz FrozenPandaz merged commit 8d0c09f into nrwl:master Feb 13, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
@meeroslav meeroslav deleted the fix-npm-lockfile-stringification branch April 27, 2023 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants