-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite): entryRoot and documentation for dts plugin #14964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandarini
requested review from
jaysoo,
ndcunningham,
bcabanes,
isaacplmann and
juristr
as code owners
February 13, 2023 16:52
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
approved these changes
Feb 13, 2023
bcabanes
approved these changes
Feb 13, 2023
isaacplmann
approved these changes
Feb 13, 2023
mandarini
force-pushed
the
fix/vite-dts-paths
branch
from
February 13, 2023 18:05
5f63dd3
to
13a7380
Compare
mandarini
force-pushed
the
fix/vite-dts-paths
branch
3 times, most recently
from
February 14, 2023 11:01
90e946d
to
ab5904f
Compare
mandarini
changed the title
fix(vite): set root and path on dts plugin
fix(vite): entryRoot and documentation for dts plugin
Feb 14, 2023
mandarini
force-pushed
the
fix/vite-dts-paths
branch
from
February 14, 2023 11:32
ab5904f
to
fc4fab1
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 15, 2023
(cherry picked from commit bff7869)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entryRoot
todts
plugindts
plugin if one wants to setskipDiagnostics
tofalse
.skipDiagnostics
off, since if they did so, they would need more configuration. Now user can check the documentation to see how it works.Here's what the new docs look like: https://nx.dev/packages/vite/documents/set-up-vite-manually#dts-plugin
Thanks to @pulecka for the correct
dts
settings!Related Issue(s)
Fixes #14955