Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): entryRoot and documentation for dts plugin #14964

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Feb 13, 2023

  • Added entryRoot to dts plugin
  • Added documentation on how to configure dts plugin if one wants to set skipDiagnostics to false.
  • Removed comment prompting the user to turn skipDiagnostics off, since if they did so, they would need more configuration. Now user can check the documentation to see how it works.

Here's what the new docs look like: https://nx.dev/packages/vite/documents/set-up-vite-manually#dts-plugin

Thanks to @pulecka for the correct dts settings!

Related Issue(s)

Fixes #14955

@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 11:34AM (UTC)

@mandarini mandarini self-assigned this Feb 13, 2023
@mandarini mandarini enabled auto-merge (squash) February 13, 2023 16:59
@mandarini mandarini force-pushed the fix/vite-dts-paths branch 3 times, most recently from 90e946d to ab5904f Compare February 14, 2023 11:01
@mandarini mandarini changed the title fix(vite): set root and path on dts plugin fix(vite): entryRoot and documentation for dts plugin Feb 14, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite executor doesn't replace TSConfig paths for buildable libraries
4 participants