Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): do not always use yarn as package manager in the gitlab ci t… #14978

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

JKapitein
Copy link
Contributor

Current Behavior

Generating a GitLab CI script will use the package manager variable for some steps, and locked yarn for others

Expected Behavior

The CI script should use the configured package manager for all steps

Related Issue(s)

@vercel
Copy link

vercel bot commented Feb 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 0:00AM (UTC)

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you!

@meeroslav meeroslav self-assigned this Feb 14, 2023
@meeroslav
Copy link
Contributor

Can you change the commit message from fix(nx) to fix(core) so the commit passes?

@meeroslav meeroslav added type: bug scope: core core nx functionality labels Feb 14, 2023
@JKapitein JKapitein changed the title fix(nx): do not always use yarn as package manager in the gitlab ci t… fix(core): do not always use yarn as package manager in the gitlab ci t… Feb 14, 2023
@JKapitein
Copy link
Contributor Author

JKapitein commented Feb 14, 2023

Whelp, messed that up. One moment, might just re-create the PR

Alright, that should be good.

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants