Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundling): make rollup executor return outfile for node executor #14989

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

cm-ayf
Copy link
Contributor

@cm-ayf cm-ayf commented Feb 14, 2023

Current Behavior

Currently, @nrwl/rollup:rollup executor does not return outfile: string, so it could not be used with executors like @nrwl/node:node.

Expected Behavior

This PR enables rollup executor to return outfile and enable node executor to use this as buildTarget.
I tested this behavior using local-registry, but did not have idea where to write such test.

No breaking changes are included. Unit test and rollup-e2e passed without modification.

Related Issue(s)

Fixes #14868

@vercel
Copy link

vercel bot commented Feb 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 14, 2023 at 3:54PM (UTC)

@mandarini mandarini merged commit bd2a1ae into nrwl:master Feb 15, 2023
FrozenPandaz pushed a commit that referenced this pull request Feb 15, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/rollup rollup executor returns outfile
2 participants