Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): v7 vite settings docs remove rootMain #14992

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

mandarini
Copy link
Member

  • Update Storybook 7 vite docs
  • Remove rootMain from everywhere

@vercel
Copy link

vercel bot commented Feb 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 5:07PM (UTC)

@philipjfulcher
Copy link
Collaborator

Our Storybook configs are broken on master right now, so I can't verify the main.js changes. I'll follow-up later

@mandarini mandarini merged commit 1b64e17 into nrwl:master Feb 15, 2023
@mandarini mandarini linked an issue Feb 15, 2023 that may be closed by this pull request
@mandarini
Copy link
Member Author

Our Storybook configs are broken on master right now, so I can't verify the main.js changes. I'll follow-up later

Oh no!!! Let me know if I can help!!!

FrozenPandaz pushed a commit that referenced this pull request Feb 15, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration update-15-7-0 prints a broken link
4 participants