fix(linter): ng-package.json format #14996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5b5dc5f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
wSedlacek
changed the title
wSedlacek
force-pushed
the
hotfix/secondary-imports
branch
from
3486c4e
to
5b5dc5f
Compare
meeroslav
approved these changes
Feb 15, 2023
| @@ -454,7 +454,8 @@ function fileIsSecondaryEntryPoint(file: string): boolean { | |||
| joinPathFragments(workspaceRoot, parent, 'ng-package.json') | |||
| ); | |||
| if (ngPackageContent) { | |||
| const entryFile = parseJson(ngPackageContent)?.ngPackage?.lib?.entryFile; | |||
| // https://github.com/ng-packagr/ng-packagr/blob/23c718d04eea85e015b4c261310b7bd0c39e5311/src/ng-package.schema.json#L54 | |||
There was a problem hiding this comment.
You can remove this line, otherwise looks good to me
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 15, 2023
(cherry picked from commit 8db4673)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Linting secondary entrypoints is failing.
Expected Behavior
Secondary entrypoints should be catching the special case for moudule boundries.