fix(webpack): add babelUpwardRootMode

[mandarini]

Current Behavior

If you try to import a js library in a @nrwl/webpack:webpack project, then the build fails, unless your library contains a .babelrc file. This is due to the rootmode: 'upward' setting that's used in the webpack executor.

Expected Behavior

Libraries that don't specifically need a .babelrc, should not require one.

In this PR, we are adding a flag to allow users to set rootmode: 'upward' if they need to, and only in that case we are using rootmode: 'upward' in the webpack executor. In the other cases, we are setting the .babelrc path to be that of the parent app we are building, so that the executor will not look elsewhere for a .babelrc file.

Related Issue(s)

Fixes #14807

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 17, 2023 at 4:46PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ba31145. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=861bad90d8fc24458f6daf90c2bf817bee2afb6c --head=ba31145615e803b738fc0d51088ec9a1052885ef --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx affected --target=test --base=861bad90d8fc24458f6daf90c2bf817bee2afb6c --head=ba31145615e803b738fc0d51088ec9a1052885ef --parallel=1
• nx affected --target=lint --base=861bad90d8fc24458f6daf90c2bf817bee2afb6c --head=ba31145615e803b738fc0d51088ec9a1052885ef --parallel=3
• nx affected --target=build --base=861bad90d8fc24458f6daf90c2bf817bee2afb6c --head=ba31145615e803b738fc0d51088ec9a1052885ef --parallel=3
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=861bad90d8fc24458f6daf90c2bf817bee2afb6c --head=ba31145615e803b738fc0d51088ec9a1052885ef
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[nartc]

This breaks the following flow:

npx nx g @nrwl/react:app my-react-app
npx nx build my-react-app # fails due to .babelrc is missing in src/.babelrc (generated .babelrc is in project root rather than source root)

-> Fix: turn on babelUpwardRootMode: true in build target

The @nrwl/js code (that gets deleted) might need to readjust but I think it still needs to be there. The following flow fails:

npx nx g @nrwl/js:lib my-js-lib

use myJsLib() in my-react-app

npx nx build my-react-app # fails due to my-js-lib is missing babelrc

--> Fix: add .babelrc manually or generate a lib with --include-babel-rc

[mandarini]

@nartc thanks for the review. It was a stupid typo on my end, instead of project root, I used src root to specify the location of the project's .babelrc file. So, it didn't find it. Now that it finds it, then all else works as expected.

The reason behind this PR is to remove .babelrc from js libs, since it's not really needed.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.