Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): misc encapuslated mode fixes #15075

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Feb 16, 2023

Current Behavior

  • Running the nx wrapper always invokes npm install due to a typo. This wasn't noticed during development as the install command previously hid its output.
  • The wrapper contains a sourceMapURL at the end which is invalid.
  • nx generate reads the root package.json to generate prompts for collectionName
  • nx list reads the root package.json to determine installed plugins
  • nx list and nx report duplicate a lot of handling for this stuff

Expected Behavior

The nx wrapper only executes an install task when its needed.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 11:08PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Feb 16, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4432145. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants