enforce-module-boundaries - banTransitiveDependencies only looks at workspace package.json

[ilijapuaca]

Current Behavior

When banTransitiveDependencies is enabled, eslint plugin will report Transitive dependencies are not allowed. Only packages defined in the "package.json" can be importedeslint[@nrwl/nx/enforce-module-boundaries], even though the dependency is present in the package.json of that module.

This seems to happen because isDirectDependency only takes the workspace package.json into account, making the rule not very usable for projects with multiple package.json files.

While I understand that a single package.json is the recommended way of dealing with dependencies, there seemed to be some momentum towards supporting use cases outside of it in this thread. It seems relatively(?) straight-forward to add support for this linting use case by simply tweaking the function noted above which would take more than a single package.json into account.

Expected Behavior

The rule does not report an error when the dependency is present in app package.json

GitHub Repo

No response

Steps to Reproduce

1. Enable @nrwl/nx/enforce-module-boundaries with banTransitiveDependencies set to true
2. Add an external dependency to app-level package.json
3. Import that dependency, an error shows up

Nx Report

>  NX   Report complete - copy this into the issue template

   Node : 14.21.1
   OS   : darwin x64
   yarn : 3.2.4

   nx : 15.0.4
   @nrwl/angular : Not Found
   @nrwl/cypress : Not Found
   @nrwl/detox : Not Found
   @nrwl/devkit : 15.0.4
   @nrwl/esbuild : Not Found
   @nrwl/eslint-plugin-nx : 15.0.4
   @nrwl/expo : Not Found
   @nrwl/express : Not Found
   @nrwl/jest : 15.0.4
   @nrwl/js : 15.0.4
   @nrwl/linter : 15.0.4
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : Not Found
   @nrwl/nx-cloud : Not Found
   @nrwl/nx-plugin : Not Found
   @nrwl/react : Not Found
   @nrwl/react-native : Not Found
   @nrwl/rollup : Not Found
   @nrwl/schematics : Not Found
   @nrwl/storybook : Not Found
   @nrwl/web : Not Found
   @nrwl/webpack : Not Found
   @nrwl/workspace : 15.0.4
   typescript : 4.8.4
   ---------------------------------------
   Local workspace plugins:
   ---------------------------------------
   Community plugins:

Failure Logs

No response

Additional Information

While I understand that per-app package.json approach seems like a somewhat controversial topic, there seems to be a large enough user base that would benefit from a small tweak to make this specific lint rule usable

[meeroslav]

Thank you, @ilijapuaca, for reporting this issue.

It is an oversight on our side, which we will fix as soon as possible.

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.