fix(angular): use sync host when generating code with angular cli schematics #15137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DarshanaHettiarachchi
approved these changes
Feb 20, 2023
DarshanaHettiarachchi
approved these changes
Feb 20, 2023
AgentEnder
approved these changes
Feb 20, 2023
Comment on lines
-506
to
+509
| const fsHost = new NxScopedHost(root); | ||
| const fsHost = new NxScopeHostUsedForWrappedSchematics( | ||
| root, | ||
| new FsTree(root, verbose) | ||
| ); |
There was a problem hiding this comment.
Is the original NxScopedHost still used anywhere? Maybe we can remove it and only keep the sync implementation
There was a problem hiding this comment.
Yeah, it's used for executors. The read operation is faster using the project graph and executors don't write back. So there's no issue with the async write implementation. That said, I plan to refactor/rename our existing host implementations, so they better represent what they are for. I'll do it in a follow-up PR later.
This was referenced Feb 21, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Generating code with Angular CLI schematics throw
Expected a synchronous delegate but got an asynchronous one. That error is handled in some cases, but it's not reliable and can't handle all scenarios. The host provided by the Angular CLI adapter has some async methods while the Angular DevKit expects them to be synchronous. This is a regression introduced in 15.7.0.Expected Behavior
Generating code with Angular CLI schematics should work correctly.
Related Issue(s)
Fixes #15124