Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): do not add typescript in new empty repos #15163

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Empty integrated repos have typescript installed.

Also, the graph fails to construct if typescript is not installed.

Expected Behavior

Empty integrated repos do not have typescript installed.

Also, the graph is able to construct if typescript is not installed

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 6:42PM (UTC)

@FrozenPandaz FrozenPandaz changed the title fix(core): disable js code analysis when typescript is not installed fix(core): do not add typescript in new empty repos Feb 24, 2023
@FrozenPandaz FrozenPandaz merged commit 3d4f590 into nrwl:master Feb 27, 2023
@FrozenPandaz FrozenPandaz deleted the rm-typescript branch February 27, 2023 17:08
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants