Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): check for source package.json on banTransitiveDependencies #15169

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

BanTransitiveDependencies only searches in the root package.json

Expected Behavior

BanTransitiveDependencies should also check the source project for package.json in case of workspaces.

Related Issue(s)

Fixes #15129

@meeroslav meeroslav self-assigned this Feb 22, 2023
@vercel
Copy link

vercel bot commented Feb 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:25AM (UTC)

@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Feb 22, 2023
@meeroslav meeroslav merged commit bacd875 into nrwl:master Feb 22, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
@meeroslav meeroslav deleted the fix-banned-transitive branch April 27, 2023 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enforce-module-boundaries - banTransitiveDependencies only looks at workspace package.json
2 participants