Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): do not install webpack and jest when cra-to-nx is using vite #15194

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 23, 2023

This PR fixes the npx nx init command when converting CRA apps to Vite.

Note: I also had to update vite config generator so TS is required when used.

Current Behavior

Running npx nx init in CRA app results in webpack and jest being installed.

Expected Behavior

Running npx nx init should only install vite.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 23, 2023 at 3:32PM (UTC)

@mandarini mandarini enabled auto-merge (squash) February 23, 2023 15:02
@mandarini mandarini merged commit ca087ed into nrwl:master Feb 23, 2023
@jaysoo jaysoo deleted the fix/cra-to-nx-no-jest branch February 23, 2023 18:49
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants