Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): automatically enable coverage with --coverage flag for vitest #15204

Merged

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Feb 23, 2023

vitest settings requires enabled = true when to turn on code coverage
automatically set enabled = true when --coverage flag is passed so it is not required to be the vite.config.ts

Current Behavior

using --coverage does not enable coverage.

Expected Behavior

using --coverage turns on vitest coverage

Related Issue(s)

Fixes #14835

@vercel
Copy link

vercel bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 23, 2023 at 10:43PM (UTC)

vitest settings requires enabled = true when to turn on code coverage
automatically set enabled = true when --coverage flag is passed so it is not required to be the
vite.config.ts

closed nrwl#14835
@barbados-clemens barbados-clemens merged commit 5bc73d3 into nrwl:master Feb 24, 2023
@barbados-clemens barbados-clemens deleted the fix/vitest-enable-coverage branch February 24, 2023 14:59
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage -option has no effect with @nrwl/vite:vitest
2 participants