fix(core): building project graphs is broken for Windows #15257
Conversation
Two problems were preventing any files from being returned from hash_files in the new native hasher on Windows:
1. The redefined `workspace_root` contained a mix of back and forward slashes,
which didn't work with the String implementation of strip_prefix
2. After that was fixed, the returned paths would have backslashes in them,
which didn't work downstream on the nodejs side
mayfieldiv
requested review from
vsavkin,
FrozenPandaz and
Cammisuli
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for the PR! We discussed the slashes while this was in development and I made an extra effort to test this on windows. And it passed for me 😮 What shell/terminal were you using? Powershell, pwsh, git bash, or cmd? |
|
Oh interesting! I'm using pwsh (not on WSL). I'm on the latest stable versions (or close to latest) of PowerShell Core v7, nodejs v18, git, nx, Windows 10, etc. |
|
Hmm the only big difference I see is that I'm on Windows 11. I wonder if Microsoft finally fixed the paths with 11 😂 Anyway, I'll give this a thorough check on Monday. Thanks again |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The new native hasher introduced in #14476 doesn't properly handle back-slashes on Windows, resulting in it always returning an empty collection of files. This breaks things like
nx graphand theaffectedcommands.This issue can be readily reproduced by following the angular tutorial through step 2 in a Windows environment with the latest pre-release of nx: https://nx.dev/angular-tutorial/2-project-graph
Following that tutorial, running
nx graphornx print-affectedonly displays the implicit dependency declared incore-e2e, since it never properly inspects any of the source files (*.ts or package.json).Expected Behavior
The native hasher should behave as expected on all platforms.