Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove logs on missing hoisted package #15295

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

meeroslav
Copy link
Contributor

Optional or nested-only packages return no version on getHoistedPackageVersion. When this function is run in the verbose mode we get log:

Could not find /user/name/path/to/repo/node_modules/package-name/package.json

Current Behavior

We see logs for "missing" hoisted packages during migration or generations if run with verbose mode.

Expected Behavior

The logs should not be shows for missing hoisted package.json

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Feb 27, 2023
@vercel
Copy link

vercel bot commented Feb 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 3:40PM (UTC)

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) February 27, 2023 16:00
@FrozenPandaz FrozenPandaz merged commit 729ff7e into nrwl:master Feb 27, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
@meeroslav meeroslav deleted the remove-log branch April 27, 2023 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants