Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): ensure readTargetOptions is compatible with nx supported range #15296

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 27, 2023

Current Behavior

The readTargetOptions function in the Nx DevKit uses some functionality that was made available in Nx 15.4.5. This breaks the compatibility of @nrwl/devkit with nx which is >=14.1 <=16.

Expected Behavior

The readTargetOptions function implementation in the Nx DevKit is compatible with nx: >=14.1 <=16.

Related Issue(s)

Fixes #14413

@leosvelperez leosvelperez self-assigned this Feb 27, 2023
@vercel
Copy link

vercel bot commented Feb 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 3:53PM (UTC)

@FrozenPandaz FrozenPandaz merged commit 50c0dac into nrwl:master Feb 27, 2023
@leosvelperez leosvelperez deleted the core/read-target-options-compat branch February 27, 2023 17:20
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

readTargetOptions devkit's function not working on Angular Workspace
3 participants