Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): fix parsing link dependencies in yarn #15364

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Mar 1, 2023

Current Behavior

Snapshots of link dependencies do not have a resolved hash:

"@webda/aws": "link:../packages/aws/",
"@webda/aws@link:packages/aws":
  version "2.4.2"
  dependencies:
    "@aws-sdk/client-acm" "^3.58.0"
    ...

This means Nx will throw an error when creating the graph.

Expected Behavior

The version of the snapshot is returned instead.

Nx is able to create a graph with link dependencies.

Related Issue(s)

Fixes #15363
Fixes #15367

@vercel
Copy link

vercel bot commented Mar 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 1, 2023 at 8:31PM (UTC)

@thtliife
Copy link

thtliife commented Mar 2, 2023

Can confirm this change resolves the problem
should also close #15367

@FrozenPandaz FrozenPandaz merged commit 65aac8e into nrwl:master Mar 2, 2023
FrozenPandaz added a commit that referenced this pull request Mar 2, 2023
@mlc-mlapis
Copy link

@FrozenPandaz This fix doesn't solve the problem for NPM. After updating to Nx 15.8.2 the problem with the error of The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received undefined remains.

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants