fix(core): mark package.json dependencies as static #15381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysoo
requested review from
vsavkin,
FrozenPandaz and
AgentEnder
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
approved these changes
Mar 2, 2023
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1dbbda7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
jaysoo
force-pushed
the
fix/explicit-package-json-is-static
branch
from
9d9be8e
to
f3b77b3
Compare
JamesHenry
approved these changes
Mar 2, 2023
jaysoo
force-pushed
the
fix/explicit-package-json-is-static
branch
from
f3b77b3
to
c72377d
Compare
jaysoo
force-pushed
the
fix/explicit-package-json-is-static
branch
from
c72377d
to
1dbbda7
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 2, 2023
(cherry picked from commit aaed63b)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
package.jsondeps are marked as dynamic.Repro: https://github.com/jaysoo/graph-issue (
test -> test2is located viapackages/test/package.jsonand should be static but is marked dynamic)Current Behavior
Expected Behavior
Related Issue(s)
Fixes #