Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure correct $schema path is generated when adding project configuration #15463

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 6, 2023

Current Behavior

When adding a project configuration, if the config being passed contains the $schema property set, it overwrites the one that gets calculated based on the project root.

Expected Behavior

Adding a project configuration should always set the calculated $schema path.

Related Issue(s)

Fixes #15429

@leosvelperez leosvelperez self-assigned this Mar 6, 2023
@vercel
Copy link

vercel bot commented Mar 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 10:34AM (UTC)

@leosvelperez leosvelperez merged commit 02a450e into nrwl:master Mar 6, 2023
@leosvelperez leosvelperez deleted the core/project-schema-overwrite branch March 6, 2023 14:46
FrozenPandaz pushed a commit that referenced this pull request Mar 8, 2023
nartc pushed a commit to nartc/nx that referenced this pull request Mar 9, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

project.json "$schema" property is incorrect after @nrwl:angular/application generator
3 participants