-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): ensure correct $schema path is generated when adding project configuration #15463
Merged
leosvelperez
merged 1 commit into
nrwl:master
from
leosvelperez:core/project-schema-overwrite
Mar 6, 2023
Merged
fix(core): ensure correct $schema path is generated when adding project configuration #15463
leosvelperez
merged 1 commit into
nrwl:master
from
leosvelperez:core/project-schema-overwrite
Mar 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
core/project-schema-overwrite
branch
from
March 6, 2023 10:30
053387c
to
e1dc07a
Compare
leosvelperez
requested review from
vsavkin,
FrozenPandaz,
AgentEnder and
Coly010
as code owners
March 6, 2023 11:18
Coly010
approved these changes
Mar 6, 2023
AgentEnder
approved these changes
Mar 6, 2023
nartc
pushed a commit
to nartc/nx
that referenced
this pull request
Mar 9, 2023
…ct configuration (nrwl#15463)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When adding a project configuration, if the config being passed contains the
$schema
property set, it overwrites the one that gets calculated based on the project root.Expected Behavior
Adding a project configuration should always set the calculated
$schema
path.Related Issue(s)
Fixes #15429