New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): move checkAndCleanWithSemver to devkit #15505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysoo
requested review from
FrozenPandaz,
AgentEnder,
vsavkin,
mandarini,
Coly010,
barbados-clemens,
nartc,
ndcunningham,
xiongemi and
leosvelperez
as code owners
March 7, 2023 15:24
jaysoo
force-pushed
the
cleanup/move-semver-util-to-devkit
branch
from
March 7, 2023 15:25
c877aae
to
a6f5471
Compare
mandarini
approved these changes
Mar 7, 2023
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nartc
approved these changes
Mar 7, 2023
Coly010
approved these changes
Mar 7, 2023
FrozenPandaz
approved these changes
Mar 7, 2023
xiongemi
approved these changes
Mar 7, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
checkAndCleanWithSemver
function from@nrwl/workspace
to@nrwl/devkit
and mark the former as deprecated. There are still some projects such asnx-tools
that import from it.Also removed the unused function from
nx
package. Looks like it was copied and pasted there but it was unused.