Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): move checkAndCleanWithSemver to devkit #15505

Merged
merged 1 commit into from Mar 7, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 7, 2023

This PR moves checkAndCleanWithSemver function from @nrwl/workspace to @nrwl/devkit and mark the former as deprecated. There are still some projects such as nx-tools that import from it.

Also removed the unused function from nx package. Looks like it was copied and pasted there but it was unused.

@jaysoo jaysoo force-pushed the cleanup/move-semver-util-to-devkit branch from c877aae to a6f5471 Compare March 7, 2023 15:25
@vercel
Copy link

vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 3:30PM (UTC)

@jaysoo jaysoo merged commit 47fd3a2 into nrwl:master Mar 7, 2023
@jaysoo jaysoo deleted the cleanup/move-semver-util-to-devkit branch March 7, 2023 18:19
nartc pushed a commit to nartc/nx that referenced this pull request Mar 9, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants