fix(core): issue with registering file dependencies #15523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forivall
requested review from
vsavkin,
FrozenPandaz and
AgentEnder
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e505bbf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
forivall
force-pushed
the
fix-race-condition-error-in-project-graph
branch
from
19d735d
to
e505bbf
Compare
|
Added a unit test which fails without the fix, and is fixed by the fix. |
FrozenPandaz
approved these changes
Mar 8, 2023
nartc
pushed a commit
to nartc/nx
that referenced
this pull request
Mar 9, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 10, 2023
(cherry picked from commit ac9c7e9)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Files wont have all the dependencies in the project graph
Expected Behavior
Files are once again reported with the correct dependencies in the project graph
Related Issue(s)
When i encountered the issue was having inconsistent (race-condition) behaviour based on the execution of the dependency analysis workers, so I didnt want to create a repro right out of the gate, so no issue, unfortunately. Now that I know the root cause, i can create a reproduction if desired, but I think the unit test is sufficient. This may fix some linting bugs.
Fixes #