Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): negative implicit dependencies should exclude statically detected dependencies #15546

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Mar 8, 2023

Current Behavior

Excluded implicit dependencies can only remove deps that are implicit, which is a breaking change from prior behavior

Expected Behavior

Excluded implicit dependencies are left in the array s.t. they can later be used to remove static deps, the prior behavior

Related Issue(s)

Fixes #14860
Fixes #15605

@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 11:04PM (UTC)

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this on the lerna codebase where we are observing this issue

@AgentEnder AgentEnder force-pushed the fix/include-negative-implicit-deps-for-later branch from 292c628 to 2cb62fc Compare March 13, 2023 23:01
@AgentEnder AgentEnder merged commit 9acd775 into nrwl:master Mar 14, 2023
@AgentEnder AgentEnder deleted the fix/include-negative-implicit-deps-for-later branch March 14, 2023 13:49
FrozenPandaz pushed a commit that referenced this pull request Mar 15, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants