-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): negative implicit dependencies should exclude statically detected dependencies #15546
fix(core): negative implicit dependencies should exclude statically detected dependencies #15546
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified this on the lerna codebase where we are observing this issue
…etected dependencies
292c628
to
2cb62fc
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Excluded implicit dependencies can only remove deps that are implicit, which is a breaking change from prior behavior
Expected Behavior
Excluded implicit dependencies are left in the array s.t. they can later be used to remove static deps, the prior behavior
Related Issue(s)
Fixes #14860
Fixes #15605