Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): only perform pattern matching if file input doesn't exist #15640

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

ZackDeRose
Copy link
Member

Current Behavior

We noticed via our benchmarks that Nx performance had degraded between 15.8.2 and 15.8.3 releases, we traced the performance to this code that we've reverting.

Expected Behavior

Should not have a performance degradation following 15.8.3 release.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Mar 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 6:11PM (UTC)

@AgentEnder AgentEnder changed the title fix(nx): reverting observed performance degradation fix(core): only perform pattern matching if file input doesn't exist Mar 14, 2023
@AgentEnder AgentEnder merged commit 5add52b into nrwl:master Mar 14, 2023
FrozenPandaz pushed a commit that referenced this pull request Mar 15, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants