fix(core): nx migrate should accept tags other than latest and next for community packages #15673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
requested changes
Mar 14, 2023
| // This doesn't seem like a valid version, lets check if its a tag on the registry. | ||
| if (!coerce(version)) | ||
| return normalizeVersion( | ||
| execSync(`npm view ${pkg}@version version`).toString().trim() |
There was a problem hiding this comment.
Use packageRegistryView
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bf66b65. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/npm-migrate-unknown-tags
branch
from
bbe134e
to
f59b668
Compare
…or community packages
AgentEnder
force-pushed
the
fix/npm-migrate-unknown-tags
branch
from
f59b668
to
a5c9e93
Compare
FrozenPandaz
requested changes
Mar 15, 2023
FrozenPandaz
requested changes
Mar 15, 2023
AgentEnder
force-pushed
the
fix/npm-migrate-unknown-tags
branch
from
1f8106a
to
fb3528f
Compare
|
Great stuff. @AgentEnder the version used was 6.0.0-A.3 because of a split taking care only of part[0] and part[1] |
AgentEnder
force-pushed
the
fix/npm-migrate-unknown-tags
branch
from
76aed37
to
8d7ec36
Compare
AgentEnder
force-pushed
the
fix/npm-migrate-unknown-tags
branch
from
8d7ec36
to
bf66b65
Compare
FrozenPandaz
approved these changes
Mar 16, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
nx migrate mypackage@alphafails, resolves the version as 0.0.0 since the tag is not normalized properly.Expected Behavior
nx migrate mypackage@alphafails, resolves the version as 0.0.0 since the tag is not normalized properly.Alt solutions:
Instead of resolving on the registry ahead of time, we could feasibly just inline a list of accepted tags. This wouldn't fix the issue in the general case, but realistically a list of
['prev', 'previous', 'next', 'latest', 'beta', 'alpha', 'rc', 'dev']would likely hit most use cases.Related Issue(s)
Fixes #15633