Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emitDecoratorMetadata not working #15702

Closed
TomMettam opened this issue Mar 16, 2023 · 2 comments
Closed

emitDecoratorMetadata not working #15702

TomMettam opened this issue Mar 16, 2023 · 2 comments

Comments

@TomMettam
Copy link

Current Behavior

I've recently ported my application (to nx:node) , which depends heavily on decorators and specifically the 'design:type' metadata which should be emitted when "emitDecoratorMetadata" is set to True.

I've set this in all of my config files, but I cannot get "nx build" to obey this setting. None of the generated files contain "design:type".

Expected Behavior

emitDecoratorMetadata should emit the "design:type" decorator metadata

GitHub Repo

https://github.com/TomMettam/nx-metadata-fail

Steps to Reproduce

See github repo.

Working plain-typescript project: https://github.com/TomMettam/metadata-working

Nx Report

>  NX   Report complete - copy this into the issue template

   Node : 18.14.2
   OS   : linux x64
   npm  : 9.5.0
   
   nx                      : 15.8.6
   @nrwl/js                : 15.8.6
   @nrwl/jest              : 15.8.6
   @nrwl/linter            : 15.8.6
   @nrwl/workspace         : 15.8.6
   @nrwl/cli               : 15.8.6
   @nrwl/devkit            : 15.8.6
   @nrwl/esbuild           : 15.8.6
   @nrwl/eslint-plugin-nx  : 15.8.6
   @nrwl/node              : 15.8.6
   @nrwl/tao               : 15.8.6
   @nrwl/webpack           : 15.8.6
   typescript              : 4.9.5

Failure Logs

No response

Additional Information

No response

@AgentEnder
Copy link
Member

This is likely because you are using esbuild in the nx repo - if you use @nrwl/js:tsc instead I'd expect it to work. evanw/esbuild#257 (comment)

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants