Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nrwl/workspace:move should produce more readable output #15745

Open
1 task
Den-dp opened this issue Mar 18, 2023 · 2 comments
Open
1 task

@nrwl/workspace:move should produce more readable output #15745

Den-dp opened this issue Mar 18, 2023 · 2 comments

Comments

@Den-dp
Copy link
Contributor

Den-dp commented Mar 18, 2023

Description

Find a way to improve @nrwl/workspace:move logs readability (by grouping operations or/and files).

Motivation

Currently, logs are hard to read.

F.e. run

nx generate @nrwl/workspace:move --project feature-tools risk/feature-tools

and try to find the line where libs/feature-tools/project.json was DELETEd and CREATEd.

image

Suggested Implementation

  • Group by operation (not ideal b/c file positions feels so random):
DELETE libs/feature-tools/project.json
DELETE libs/feature-tools/.eslintrc.json
DELETE libs/feature-tools/jest.config.ts
DELETE libs/feature-tools/README.md
DELETE libs/feature-tools/src/index.ts
DELETE libs/feature-tools/src/lib/feature-tools.component.ts
DELETE libs/feature-tools/src/lib/lib.routes.ts
DELETE libs/feature-tools/src/lib/one.component.ts
DELETE libs/feature-tools/src/lib/two.component.ts
DELETE libs/feature-tools/src/test-setup.ts
DELETE libs/feature-tools/tsconfig.json
DELETE libs/feature-tools/tsconfig.lib.json
DELETE libs/feature-tools/tsconfig.spec.json
CREATE libs/risk/feature-tools/.eslintrc.json
CREATE libs/risk/feature-tools/jest.config.ts
CREATE libs/risk/feature-tools/README.md
CREATE libs/risk/feature-tools/src/index.ts
CREATE libs/risk/feature-tools/src/lib/feature-tools.component.ts
CREATE libs/risk/feature-tools/src/lib/lib.routes.ts
CREATE libs/risk/feature-tools/src/lib/one.component.ts
CREATE libs/risk/feature-tools/src/lib/two.component.ts
CREATE libs/risk/feature-tools/src/test-setup.ts
CREATE libs/risk/feature-tools/tsconfig.json
CREATE libs/risk/feature-tools/tsconfig.lib.json
CREATE libs/risk/feature-tools/tsconfig.spec.json
CREATE libs/risk/feature-tools/project.json
UPDATE tsconfig.base.json
  • Even better is group + sort by filepath (so a file position is consistent across groups and relatively easy to find)
DELETE libs/feature-tools/.eslintrc.json
DELETE libs/feature-tools/README.md
DELETE libs/feature-tools/jest.config.ts
DELETE libs/feature-tools/project.json
DELETE libs/feature-tools/src/index.ts
DELETE libs/feature-tools/src/lib/feature-tools.component.ts
DELETE libs/feature-tools/src/lib/lib.routes.ts
DELETE libs/feature-tools/src/lib/one.component.ts
DELETE libs/feature-tools/src/lib/two.component.ts
DELETE libs/feature-tools/src/test-setup.ts
DELETE libs/feature-tools/tsconfig.json
DELETE libs/feature-tools/tsconfig.lib.json
DELETE libs/feature-tools/tsconfig.spec.json
CREATE libs/risk/feature-tools/.eslintrc.json
CREATE libs/risk/feature-tools/README.md
CREATE libs/risk/feature-tools/jest.config.ts
CREATE libs/risk/feature-tools/project.json
CREATE libs/risk/feature-tools/src/index.ts
CREATE libs/risk/feature-tools/src/lib/feature-tools.component.ts
CREATE libs/risk/feature-tools/src/lib/lib.routes.ts
CREATE libs/risk/feature-tools/src/lib/one.component.ts
CREATE libs/risk/feature-tools/src/lib/two.component.ts
CREATE libs/risk/feature-tools/src/test-setup.ts
CREATE libs/risk/feature-tools/tsconfig.json
CREATE libs/risk/feature-tools/tsconfig.lib.json
CREATE libs/risk/feature-tools/tsconfig.spec.json
UPDATE tsconfig.base.json
  • Group by file:
DELETE libs/feature-tools/.eslintrc.json
CREATE libs/risk/feature-tools/.eslintrc.json
DELETE libs/feature-tools/README.md
CREATE libs/risk/feature-tools/README.md
DELETE libs/feature-tools/jest.config.ts
CREATE libs/risk/feature-tools/jest.config.ts
DELETE libs/feature-tools/project.json
CREATE libs/risk/feature-tools/project.json
DELETE libs/feature-tools/src/index.ts
CREATE libs/risk/feature-tools/src/index.ts
DELETE libs/feature-tools/src/lib/feature-tools.component.ts
CREATE libs/risk/feature-tools/src/lib/feature-tools.component.ts
DELETE libs/feature-tools/src/lib/lib.routes.ts
CREATE libs/risk/feature-tools/src/lib/lib.routes.ts
DELETE libs/feature-tools/src/lib/one.component.ts
CREATE libs/risk/feature-tools/src/lib/one.component.ts
DELETE libs/feature-tools/src/lib/two.component.ts
CREATE libs/risk/feature-tools/src/lib/two.component.ts
DELETE libs/feature-tools/src/test-setup.ts
CREATE libs/risk/feature-tools/src/test-setup.ts
DELETE libs/feature-tools/tsconfig.json
CREATE libs/risk/feature-tools/tsconfig.json
DELETE libs/feature-tools/tsconfig.lib.json
CREATE libs/risk/feature-tools/tsconfig.lib.json
DELETE libs/feature-tools/tsconfig.spec.json
CREATE libs/risk/feature-tools/tsconfig.spec.json
UPDATE tsconfig.base.json
  • MOVE operation
MOVE libs/feature-tools/.eslintrc.json -> libs/risk/feature-tools/.eslintrc.json
MOVE libs/feature-tools/README.md -> libs/risk/feature-tools/README.md
MOVE libs/feature-tools/jest.config.ts -> libs/risk/feature-tools/jest.config.ts
MOVE libs/feature-tools/project.json -> libs/risk/feature-tools/project.json
MOVE libs/feature-tools/src/index.ts -> libs/risk/feature-tools/src/index.ts
MOVE libs/feature-tools/src/lib/feature-tools.component.ts -> libs/risk/feature-tools/src/lib/feature-tools.component.ts
MOVE libs/feature-tools/src/lib/lib.routes.ts -> libs/risk/feature-tools/src/lib/lib.routes.ts
MOVE libs/feature-tools/src/lib/one.component.ts -> libs/risk/feature-tools/src/lib/one.component.ts
MOVE libs/feature-tools/src/lib/two.component.ts -> libs/risk/feature-tools/src/lib/two.component.ts
MOVE libs/feature-tools/src/test-setup.ts -> libs/risk/feature-tools/src/test-setup.ts
MOVE libs/feature-tools/tsconfig.json -> libs/risk/feature-tools/tsconfig.json
MOVE libs/feature-tools/tsconfig.lib.json -> libs/risk/feature-tools/tsconfig.lib.json
MOVE libs/feature-tools/tsconfig.spec.json -> libs/risk/feature-tools/tsconfig.spec.json
UPDATE tsconfig.base.json
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Nov 25, 2023
@Den-dp
Copy link
Contributor Author

Den-dp commented Nov 25, 2023

should be a low-hanging fruit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants