Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix wrong tsconfig option name in webpack-dev-server implementation #15765

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 20, 2023

Current Behavior

When serving an application using buildable libraries, it errors because of an undefined tsConfig path. This is happening because a wrong option name is being used in the webpack-dev-server executor implementation.

Expected Behavior

Serving an application with the webpack-dev-server executor and using buildable libraries should work correctly.

Related Issue(s)

Fixes #15746

@leosvelperez leosvelperez self-assigned this Mar 20, 2023
@vercel
Copy link

vercel bot commented Mar 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 20, 2023 at 9:18AM (UTC)

@leosvelperez leosvelperez marked this pull request as ready for review March 20, 2023 09:42
@leosvelperez leosvelperez merged commit f2fb4c8 into nrwl:master Mar 20, 2023
@leosvelperez leosvelperez deleted the angular/wrong-tsconfig-option branch March 20, 2023 09:45
FrozenPandaz pushed a commit that referenced this pull request Mar 22, 2023
@HmFlashy
Copy link

HmFlashy commented Mar 23, 2023

When will it be published ? thanks
I get the same error in our Angular workspaces.

Getting this

npm run dashboard:dev:ssr                                 

> web@2.0.0 dashboard:dev:ssr
> ng run dashboard:serve-ssr


 >  NX   angular.json format is incorrect

   Nx no longer supports the v2 format of angular.json.
   Run "nx g @nrwl/workspace:fix-configuration" to split angular.json into individual project.json files. (Recommended)
   If you want to preserve angular.json, run "nx g @nrwl/workspace:fix-configuration --reformat"

Then this

./node_modules/.bin/nx g @nrwl/workspace:fix-configuration --reformatnx g fix-configuration --dry-run

 >  NX   The "path" argument must be of type string. Received undefined

   
   Because of the error the Nx daemon process has exited. The next Nx command is going to restart the daemon process.
   If the error persists, please run "nx reset".

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants