Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nx migrate latest should update buildable lib dependency versions #15928

Open
1 task
markgoho opened this issue Mar 28, 2023 · 2 comments
Open
1 task

nx migrate latest should update buildable lib dependency versions #15928

markgoho opened this issue Mar 28, 2023 · 2 comments
Assignees
Labels
scope: core core nx functionality type: feature

Comments

@markgoho
Copy link
Contributor

Description

When running nx migrate latest a migration script should be added to update all dependency versions in any buildable libraries.

Motivation

Right now, we have an application with many buildable libraries. When we generate those libraries for the first time the generator uses the current version of Angular to write the package.json e.g.

"peerDependencies": {
  "@angular/common": "^12.2.0",
  "@angular/core": "^12.2.0"
},
"dependencies": {
  "tslib": "^2.3.0"
}

However, as we migrate to new versions of Angular, these package.json are left untouched. The library above was created more than a year ago and has remained on Angular 12 since that time.

Suggested Implementation

I think this feature would enhance the migration functionality to ensure some agreement between the root package.json Angular version and the version present in all the libraries.

It seems like there may be some folks out there that would want to keep their buildable libraries on the version of Angular that they were initially built with, but my assumption is that a vast majority of folks would rather have these angular versions update as the project Angular version is updated.

Alternate Implementations

We could do a codebase search/find and replace to update all outdated versions of Angular to the one that's currently active in the root.

@AgentEnder AgentEnder added the scope: core core nx functionality label Mar 28, 2023
@thatsBruno
Copy link

I ran into the same issue, any work around?

@sebastianhaberey
Copy link

I was wondering the same today when I stumbled across the peerDependencies of my libraries. They were all still Angular 15 even though I thought I had migrated my project completely to Angular 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: core core nx functionality type: feature
Projects
None yet
Development

No branches or pull requests

4 participants