Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): allow npmScope to be single @ #16053

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 3, 2023

Current Behavior

We changed behaviour such that when the npmScope is empty, we no longer default to using '@' for the importPath for libraries.
If people set their npmScope to @, we transform this to @@/{package}

Expected Behavior

We should allow people to use @ as their npmScope, without transforming it.

Related Issue(s)

Fixes #14693

@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 9:56am

@AgentEnder AgentEnder changed the title fix(core): allow npmScope to be single @ fix(misc): allow npmScope to be single @ Apr 3, 2023
@AgentEnder AgentEnder merged commit c0d95a7 into nrwl:master Apr 3, 2023
@Coly010 Coly010 deleted the core/allow-@-for-npmScope branch April 3, 2023 14:26
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behaviour change: npmScope is omitted entirely when set to "" instead of setting the scope to @/
2 participants