Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): don't error if lock file not present when precomputing js dependencies #16094

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

AgentEnder
Copy link
Member

Current Behavior

When running npm i, yarn, pnpm i without a lock file present JS analysis errors and doesn't add dependencies. This can cause a project graph that contains no source file related edges, thus causing builds to not respect target dependencies as one may expect.

Expected Behavior

JS analysis doesn't error if no lock file present.

Related Issue(s)

Related to: #16071

@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 7:37pm

@FrozenPandaz FrozenPandaz merged commit 18c016b into nrwl:master Apr 4, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants