fix(core): run-many doesn't strip quotes surrounding target names #16211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
requested changes
Apr 13, 2023
| return args.split(','); | ||
| const items = args.split(','); | ||
| return items.map((i) => | ||
| i.startsWith('"') && i.endsWith('"') ? i.slice(1, -1) : i |
There was a problem hiding this comment.
Should we handle single quotes?
There was a problem hiding this comment.
Nope - double checked and we only handle double quotes for nx run as well - one could probably argue that this should change, but I digress. Lets fix this first, can attack single quotes more holistically later.
FrozenPandaz
approved these changes
Apr 13, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
run-many doesn't strip quotes surrounding its targets, which can cause unexpected behavior
Expected Behavior
run-many strips quotes
Related Issue(s)
Fixes #16203