fix(react): install rollup package when generating lib

[mandarini]

Current Behavior

The @nrwl/rollup package is not getting installed when generating a buildable react library that uses the @nrwl/rollup:rollup executor, which results in the following error:

npx nx build rollib

 >  NX   Ran target build for project rollib (53ms)

    ✖    0/0 failed
    ✔    0/0 succeeded [0 read from cache]

   View logs and run details at https://nx.app/runs/785BGG9zna

 >  NX   Unable to resolve @nrwl/rollup:rollup.

   Cannot find module '@nrwl/rollup/package.json'
   Require stack:
   - /Users/katerina/Projects/nrwl/test_nx_workspaces/rolls/node_modules/nx/src/utils/package-json.js
   - /Users/katerina/Projects/nrwl/test_nx_workspaces/rolls/node_modules/nx/src/utils/package-manager.js
   - /Users/katerina/Projects/nrwl/test_nx_workspaces/rolls/node_modules/nx/bin/init-local.js
   - /Users/katerina/Projects/nrwl/test_nx_workspaces/rolls/node_modules/nx/bin/nx.js
   Pass --verbose to see the stacktrace.

Expected Behavior

@nrwl/rollup package should get installed.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)			Apr 18, 2023 5:31pm

[mandarini]

The weird thing is that on line 23 of the same file we're doing ensurePackage for the @nx/rollup package, and it still doesn't get installed :/

[jaysoo]

it doesn't get added to the workspace, i think it needs to be in the init generator

[jaysoo]

We need to fix this in @nx/rollup:init generator. The bug is that @nx/rollup package is only added when compiler is swc. It should be added for all cases.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c3342bd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=5a0a4e8d26fb56a3e0ae5c400f56068d4ae38c73 --head=c3342bd98177e7e7eee4f93bdffcccc01b7228e4 --parallel=1
• nx affected --target=test --base=5a0a4e8d26fb56a3e0ae5c400f56068d4ae38c73 --head=c3342bd98177e7e7eee4f93bdffcccc01b7228e4 --parallel=1
• nx affected --target=build --base=5a0a4e8d26fb56a3e0ae5c400f56068d4ae38c73 --head=c3342bd98177e7e7eee4f93bdffcccc01b7228e4 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=lint --base=5a0a4e8d26fb56a3e0ae5c400f56068d4ae38c73 --head=c3342bd98177e7e7eee4f93bdffcccc01b7228e4 --parallel=3
• nx-cloud record -- nx format:check --base=5a0a4e8d26fb56a3e0ae5c400f56068d4ae38c73 --head=c3342bd98177e7e7eee4f93bdffcccc01b7228e4
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.