fix(core): do not attempt to remove non-existent package from package.json #16399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
meeroslav
changed the title
mandarini
approved these changes
Apr 19, 2023
jaysoo
approved these changes
Apr 19, 2023
meeroslav
requested review from
FrozenPandaz,
AgentEnder and
vsavkin
as code owners
AgentEnder
approved these changes
Apr 19, 2023
Comment on lines
+40
to
+51
| expect( | ||
| packageJson.devDependencies['@nrwl/jest'] || | ||
| packageJson.devDependencies['@nx/jest'] | ||
| ).toBeDefined(); | ||
| expect( | ||
| packageJson.devDependencies['@nrwl/vite'] || | ||
| packageJson.devDependencies['@nx/vite'] | ||
| ).toBeUndefined(); | ||
| expect( | ||
| packageJson.devDependencies['@nrwl/webpack'] || | ||
| packageJson.devDependencies['@nx/webpack'] | ||
| ).toBeDefined(); |
There was a problem hiding this comment.
nx init should always add the @nx scoped package right? I'd think you could just check for it.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #