feat(angular): add migration to remove protractor generator defaults #16409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
leosvelperez
requested changes
Apr 20, 2023
leosvelperez
requested changes
Apr 20, 2023
packages/angular/src/migrations/update-16-0-0/remove-protractor-defaults.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/migrations/update-16-0-0/remove-protractor-defaults.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
remove-protractor-defaults-migration
branch
from
b0fd703
to
f4b27fa
Compare
Coly010
force-pushed
the
remove-protractor-defaults-migration
branch
from
f4b27fa
to
a9b6626
Compare
leosvelperez
requested changes
Apr 21, 2023
Coly010
force-pushed
the
remove-protractor-defaults-migration
branch
from
a9b6626
to
752906e
Compare
leosvelperez
approved these changes
Apr 21, 2023
Coly010
force-pushed
the
remove-protractor-defaults-migration
branch
from
752906e
to
5d19b9a
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We removed protractor from generator options for application, host and remote.
Expected Behavior
We should add a migration to ensure defaults do not cause errors
Related Issue(s)
Fixes #