Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): create-nx-workspace should work with custom presets on windows #16473

Conversation

AgentEnder
Copy link
Member

Current Behavior

create-nx-workspace fails when trying to run something like this on windows:

spawn('npx', args, {
 // ... some options
})

This is because npx is actually npx.cmd on windows - but, using shell: true also fixes it and handles similar problems for yarn or pnpx.

Expected Behavior

create-nx-workspace can generate custom presets on windows

Related Issue(s)

Fixes #16231

@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 21, 2023 8:19pm

@AgentEnder AgentEnder force-pushed the fix/enoent-when-generating-custom-preset-on-windows branch from dece7d3 to 6400b70 Compare April 21, 2023 20:15
@FrozenPandaz FrozenPandaz merged commit 04a0c77 into nrwl:master Apr 21, 2023
3 checks passed
@shairez
Copy link
Contributor

shairez commented Apr 22, 2023

great job @AgentEnder ! thank you for this!

FrozenPandaz pushed a commit that referenced this pull request Apr 24, 2023
FrozenPandaz pushed a commit that referenced this pull request Apr 24, 2023
FrozenPandaz pushed a commit that referenced this pull request Apr 25, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
@AgentEnder AgentEnder deleted the fix/enoent-when-generating-custom-preset-on-windows branch April 28, 2023 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-nx-workspace with custom preset is broken on windows
3 participants