Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add a monkey-patch for require to use @nx packages instea… #16511

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

…d of @nrwl

Current Behavior

Deep imports to @nrwl/ packages can break with the rescope.

Expected Behavior

Hopefully, most of these imports are done within the Nx process (generators, executors, etc.). Sometimes, they can be outside of these contexts, such as worker processes. We can address those by actually re-exporting the failing imports.

This monkey patch gives us most of the backwards compatibility without adding a lot of unnecessary code to maintain.

Also, there is a file from nx that has been removed, which breaks backwards compatibility. This adds the file back which re-exports the same tokens from the new file.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 4:51pm

@FrozenPandaz FrozenPandaz merged commit 26ad8eb into nrwl:master Apr 24, 2023
15 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants