Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): rust based watcher #16915

Merged
merged 38 commits into from Jun 1, 2023
Merged

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented May 10, 2023

Current Behavior

Nx currently uses @parcel/watcher for its watch implementation. This has a few limitations:

  1. Nested git ignores are not handled
  2. Multiple watches on linux causes some issues (the reason why we had to disable output watching in linux)

Expected Behavior

A new watcher is implemented with Rust, and be toggled on with setting "nativeWatcher": true in nx.json (taskRunnerOptions > default > nativeWatcher) or by using the NX_NATIVE_WATCHER=true env variable.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 4:56pm

@nrwl nrwl deleted a comment from nx-cloud bot May 25, 2023
@Cammisuli Cammisuli requested a review from a team as a code owner June 1, 2023 16:53
@vsavkin vsavkin merged commit a978ad3 into nrwl:master Jun 1, 2023
15 checks passed
@Cammisuli Cammisuli deleted the rust_based_watched branch June 1, 2023 18:51
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants