feat(js): refactor usages of npmScope #16947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
requested review from
AgentEnder,
vsavkin,
jaysoo,
mandarini,
ndcunningham,
nartc,
xiongemi,
Coly010 and
leosvelperez
as code owners
Coly010
requested changes
May 15, 2023
There was a problem hiding this comment.
This seems to be missing a file where you would also want to make the change:
https://github.com/nrwl/nx/blob/master/packages/angular/src/generators/utils/project.ts#L63
mandarini
approved these changes
May 15, 2023
FrozenPandaz
commented
May 15, 2023
| @@ -28,7 +27,7 @@ export async function migrateFromAngularCli( | |||
| ): Promise<GeneratorCallback> { | |||
| validateWorkspace(tree); | |||
| const projects = getAllProjects(tree); | |||
| const options = normalizeOptions(tree, rawOptions, projects); | |||
| const options = rawOptions; | |||
There was a problem hiding this comment.
nit: change this
| @@ -68,6 +68,7 @@ export interface NxJsonConfiguration<T = '*' | string[]> { | |||
| */ | |||
| targetDefaults?: TargetDefaults; | |||
| /** | |||
| * @deprecated This is inferred from the package.json in the workspace root. Please use {@link getNpmScope} instead. | |||
There was a problem hiding this comment.
update nx-schema.json
AgentEnder
approved these changes
May 15, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
create-nx-workspaceandnx initsetnpmScopeinnx.json.Expected Behavior
create-nx-workspaceandnx initno longer setnpmScopeinnx.json. IfnpmScopeis still innx.json, then that is still read but if not then the scope is read from the rootpackage.jsonif available. Otherwise, it will be as if there is nonpmScope.Related Issue(s)
Fixes #