> NX File change detected. Restarting... #17070

pedropmedina · 2023-05-17T20:23:50Z

Current Behavior

@nx:js:node dev server is stuck on > NX File change detected. Restarting... since upgrading to 16.2.1

Expected Behavior

Dev server to work as should. I did not have this issue with 16.1.4.

GitHub Repo

No response

Steps to Reproduce

Just run npx nx run :serve with @nx/js:node as the executor.

Nx Report

Node   : 18.16.0
   OS     : darwin arm64
   npm    : 9.5.1
   Hasher : Native

   nx                 : 16.2.1
   @nx/js             : 16.2.1
   @nx/jest           : 16.2.1
   @nx/linter         : 16.2.1
   @nx/workspace      : 16.2.1
   @nx/cypress        : 16.2.1
   @nx/devkit         : 16.2.1
   @nx/esbuild        : 16.2.1
   @nx/eslint-plugin  : 16.2.1
   @nx/express        : 16.2.1
   @nx/next           : 16.2.1
   @nx/node           : 16.2.1
   @nx/react          : 16.2.1
   @nrwl/tao          : 16.2.1
   @nx/web            : 16.2.1
   nx-cloud           : 16.0.5
   typescript         : 5.0.4
   ---------------------------------------
   Community plugins:
   @nx-tools/nx-container : 4.0.3
   @nx-tools/nx-prisma    : 4.0.3

Failure Logs

No response

Operating System

macOS
Linux
Windows
Other (Please specify)

Additional Information

No response

The text was updated successfully, but these errors were encountered:

salihsagdilek · 2023-05-17T22:58:22Z

simular issue for windows when change something, its stuck on NX File change detected. Restarting... more or less 30 sec. then restart.

  Node   : 16.20.0
   OS     : win32 x64
   npm    : 8.19.4
   Hasher : Native

   nx (global)             : 16.2.1
   nx                      : 16.2.1
   @nx/js                  : 16.2.1
   @nx/jest                : 16.2.1
   @nx/linter              : 16.2.1
   @nx/workspace           : 16.2.1
   @nx/devkit              : 16.0.0-beta.4
   @nrwl/eslint-plugin-nx  : 16.0.0-beta.4
   @nx/nest                : 16.2.1
   @nx/node                : 16.2.1
   @nrwl/tao               : 16.2.1
   @nx/vite                : 16.2.1
   @nx/webpack             : 16.2.1
   nx-cloud                : 16.0.5
   typescript              : 5.0.4
   ---------------------------------------
   Community plugins:
   @nx/eslint-plugin-nx : 16.0.0-beta.4

thenglong · 2023-05-18T08:01:09Z

Same issue here.

   Node   : 18.16.0
   OS     : win32 x64
   npm    : 9.5.1
   Hasher : Native

   nx (global)        : 16.1.4
   nx                 : 16.2.1
   @nx/js             : 16.2.1
   @nx/jest           : 16.2.1
   @nx/linter         : 16.2.1
   @nx/workspace      : 16.2.1
   @nx/devkit         : 16.2.1
   @nx/eslint-plugin  : 16.2.1
   @nx/nest           : 16.2.1
   @nx/node           : 16.2.1
   @nx/plugin         : 16.2.1
   @nrwl/tao          : 16.2.1
   @nx/webpack        : 16.2.1
   typescript         : 5.0.4

YeomansIII · 2023-05-18T17:49:43Z

Seeing the same thing here, specifically when serving a NestJS app. Interestingly this also causes my Angular 16 app to rebuild, but when I am not serving the NestJS app, the Angular app does not rebuild. Does anyone know how to get the @nx/node:node serve to output which files it saw change?

    "serve": {
      "executor": "@nx/node:node",
      "options": {
        "buildTarget": "core:build"
      }
    },

   Node   : 18.12.1
   OS     : darwin arm64
   npm    : 8.19.2
   Hasher : Native
   
   nx                 : 16.2.1
   @nx/js             : 16.2.1
   @nx/jest           : 16.2.1
   @nx/linter         : 16.2.1
   @nx/workspace      : 16.2.1
   @nx/angular        : 16.2.1
   @nx/cypress        : 16.2.1
   @nx/devkit         : 16.2.1
   @nx/eslint-plugin  : 16.2.1
   @nx/nest           : 16.2.1
   @nx/node           : 16.2.1
   @nx/plugin         : 16.2.1
   @nrwl/tao          : 16.2.1
   @nx/webpack        : 16.2.1
   typescript         : 5.0.4
   ---------------------------------------
   Community plugins:
   @nx-plus/docusaurus       : 15.0.0-rc.0
   apollo-angular            : 5.0.0
   nest-commander-schematics : 3.0.0
   ---------------------------------------
   Local workspace plugins:
         @nisra/workspace-plugin

YeomansIII · 2023-05-18T18:00:24Z

I was able to log the detected change and as I suspected it is my GraphQL schema.gql file that is autogenerated. This didn't cause issues on nx 15.

{
  changedProjects: [ 'core' ],
  changedFiles: [ { path: 'apps/core/src/schema.gql', type: 'update' } ]
}

Adding this file to a .nxignore file at the root of the repo fixes the serve build loop. Although, I'm not sure if this is necessarily a good thing or not.
https://nx.dev/reference/nxignore

In order to find the files that were being updated, I added a console.log(data); just before this line:

nx/packages/js/src/executors/node/node.impl.ts

Line 197 in 8ce9606

logger.info(`NX File change detected. Restarting...`);

The file I added it to (just for the purpose of finding the offended file), was the compiled node.impl.js in my node-modules/ folder. So the exact location of your file and line number may vary.

ibockowsky · 2023-05-25T08:17:01Z

Issue still exists on 16.2.2, building changes performance became very poor, most errors aren't logged without --verbose, but sometimes this flag isn't changing anything :/

Downgrading to 16.1.4 - much faster build :)

thenglong · 2023-05-25T14:21:41Z

Serving NestJS app in development is also very slow even though it has only a few typescript files in the project.

PointSingularity · 2023-05-25T15:09:51Z

Issue still exists on 16.2.2, building changes performance became very poor, most errors aren't logged without --verbose, but sometimes this flag isn't changing anything :/

Downgrading to 16.1.4 - much faster build :)

I'm experiencing the same with logs. I am using winston to log some stuff, and the logs completely disappeared from the console, but they are still written to a file like before.
So I am not sure what is causing that.

And it's taking full 10+ sec to change a single line.

Tirke · 2023-05-26T15:12:47Z

Experienced same problems, fixed by adding responsible files in .nxignore but we reverted anyways cause the performance are catastrophic.

jasonmacdonald · 2023-05-31T17:19:47Z

Can also confirm this issue. We had to downgrade to 16.1.4. Also confirmed that the very recent 16.3.0 did not fix the issue either.

KeithGillette · 2023-06-01T22:51:47Z

We are experiencing the same issue with versions greater than 16.1.4 and find that it is not fixed in today's release of 16.3.1. A second file change made during the > NX File change detected. Restarting... seems to wake it up.

   Node   : 16.20.0
   OS     : darwin arm64
   npm    : 8.19.4
   Hasher : Native
   
   nx             : 16.3.1
   @nx/js         : 16.3.1
   @nx/jest       : 16.3.1
   @nx/linter     : 16.3.1
   @nx/workspace  : 16.3.1
   @nx/angular    : 16.3.1
   @nx/cypress    : 16.3.1
   @nx/devkit     : 16.2.2
   @nx/node       : 16.3.1
   @nrwl/tao      : 16.3.1
   @nx/webpack    : 16.3.1
   nx-cloud       : 16.0.5
   typescript     : 5.1.3
   ---------------------------------------
   Community plugins:
   apollo-angular : 5.0.0
   ---------------------------------------
   The following packages should match the installed version of nx
     - @nx/devkit@16.2.2
     - @nrwl/devkit@16.2.2

UPDATE: Not fixed in 16.3.2, ... or 16.4.0, either.

ibockowsky · 2023-06-12T07:25:59Z

Issue still exists... Will anyone look into it?

@meeroslav

jasonmacdonald · 2023-06-12T18:25:27Z

This is blocking us from upgrading to fix another issue we are encountering, which was resolved in #16825 . Kind of stuck between a rock and a hard place now. I'm starting to regret bringing NX into our stack, as none of these issues have to do with the actual packages we use to build our app. :(

urugator · 2023-06-14T10:49:05Z

16.3.2

It watches files it did not before (causing infinite restart loops if file is generated by the restarted task)
It swallows logs from webpack.
It's slow.
The watcher crashes if it fails to kill the process (eg because it already exited):

node:internal/errors:863
  const err = new Error(message);
              ^

Error: Command failed: taskkill /pid 3180 /T /F
ERROR: The process "3180" not found.

    at ChildProcess.exithandler (node:child_process:419:12)
    at maybeClose (node:internal/child_process:1098:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5) {
  code: 128,
  killed: false,
  signal: null,
  cmd: 'taskkill /pid 3180 /T /F'
}

Node.js v19.2.0

 >  NX   Running target serve for project api failed

   Failed tasks:

   - api:serve:development

   Hint: run the command with --verbose for more details.

error Command failed with exit code 1.

ggagosh · 2023-06-15T07:50:58Z

16.3.2

Same issue for watches
It's significantly slower than the previous version 15.x 😞

Actually, slowness is more problematic, as the first one can be solved by .nxignore

meeroslav · 2023-06-15T14:12:12Z

@ndcunningham @jaysoo can one of you have a look?

danyhiol · 2023-06-19T21:53:49Z

Same here... this is killing development...

pedroqueiroz · 2023-06-23T12:49:17Z

Facing the same issues, needed to rollback to 16.1.4. :(

bcerquiare · 2023-06-23T17:52:05Z

+1 here. ~15sec when changes a single line.

KranzAklilu · 2023-06-25T05:55:32Z

Even rolling back to 16.1.4 did not work for me.
yarn nx migrate nx@16.1.4
nothing changed

edit: I had to remove my node_modules and reinstall everything. It's now working

thenglong · 2023-06-25T16:23:33Z

Even rolling back to 16.1.4 did not work for me. yarn nx migrate nx@16.1.4 nothing changed

edit: I had to remove my node_modules and reinstall everything. It's now working

I think you have to downgrade manually by edit your package.json since nx does not support migrate to lower version.

codeninja · 2023-06-26T19:32:01Z

Issue still exists on 16.4 as well.

Logging the data on this line.

{
  changedProjects: [ 'data-mongodb' ],
  changedFiles: [
    { path: 'libs/data/mongodb/src/index.ts', type: 'update' },
    { path: 'libs/data/mongodb/src/schema.prisma', type: 'update' },
    {
      path: 'libs/data/mongodb/src/typegraphql-functional-schema.prisma',
      type: 'update'
    }
  ]
}

codeninja · 2023-06-26T19:34:53Z

Even rolling back to 16.1.4 did not work for me. yarn nx migrate nx@16.1.4 nothing changed
edit: I had to remove my node_modules and reinstall everything. It's now working

I think you have to downgrade manually by edit your package.json since nx does not support migrate to lower version.

And then make sure you revert the changes to use @ns/js:node rather than @ns/node:node

PointSingularity · 2023-06-30T11:32:48Z

The issue is still present on version 16.4.1.

jaysoo · 2023-07-14T12:32:06Z

What are your restart times? Is it slow but eventually starts, or never starts?

om-mahato · 2023-07-14T12:47:34Z

@jaysoo It does restarts, after taking a sweet amount of time shared below. Though project is small and has not much modules previously used to be instant.

jaysoo · 2023-07-14T13:58:36Z

The slowness is from running a full webpack build, whereas previously it was in watch mode. I think I can get it to run in watch mode again and still queue the restart correctly. Let me take a look today.

KeithGillette · 2023-07-14T14:03:26Z

What are your restart times? Is it slow but eventually starts, or never starts?

In our project, the rebuild hangs indefinitely until a second file change is triggered, then the rebuild completes within a couple of seconds. That is, every other file change hangs.

jaysoo · 2023-07-14T14:43:34Z

In our project, the rebuild hangs indefinitely until a second file change is triggered, then the rebuild completes within a couple of seconds. That is, every other file change hangs.

Sounds like an issue with watch events. I made a note of it to investigate.

andrey59412678 · 2023-07-14T20:51:09Z

@jaysoo It does restarts, after taking a sweet amount of time shared below. Though project is small and has not much modules previously used to be instant.

same situation for me

stewones · 2023-07-15T12:52:46Z

version 16.5.2 and livereload is still insanely slow.

same here

ggagosh · 2023-07-17T08:43:35Z

The slowness is from running a full webpack build, whereas previously it was in watch mode. I think I can get it to run in watch mode again and still queue the restart correctly. Let me take a look today.

Hey @jaysoo Is there an option for us to run this in watch mode again? I'd even consider patching the package if it could help restore the previous build time. Any guidance would be appreciated. 😞

Nightbr · 2023-07-17T14:22:08Z

Same here, upgraded to 16.5.2 using webpack and it has a weird behavior when NX File change detected only trigger when we change code in libs and nothing happened if we change code in apps. Also very very slow live-reload.

Happy to give more information to help debug this if necessary 👌

PointSingularity · 2023-07-18T13:56:05Z

@jaysoo Just tried the new 16.5.3 version with my webpack Node app, and the changes happen almost instantly now.
Thank you 😄

jasonmacdonald · 2023-07-18T14:25:00Z

Not sure why, but my file changes take like 5 seconds to be detected now, and setting debounce seems to have no affect.

stewones · 2023-07-18T14:45:55Z

@jaysoo all good here now, thanks my man!

ggagosh · 2023-07-18T14:49:02Z

@jaysoo works like a charm. ty man 🙌

kurt-west · 2023-07-18T15:57:19Z

@jaysoo thank you for your efforts, really appreciate you bringing the webpack output back.

jaysoo · 2023-07-18T16:03:13Z

We'll cut a beta for people to test out soon. I did some testing on my example apps and a large TS monorepo. The watch mode will help most people, and for complete correctness (but slower) people can opt into --runBuildTargetDependencies, which will rebuild all dependencies (with caching) when changes come in.

PointSingularity · 2023-07-18T17:21:18Z

@jaysoo But #18145 is already released with 16.5.3, or were you thinking of something else?

jaysoo · 2023-07-18T18:58:17Z

@jaysoo But #18145 is already released with 16.5.3, or were you thinking of something else?

Yes, you're right, I was thinking of something else in our beta releases. This fix was released in 16.5.3.

Cheers!

andrey59412678 · 2023-07-19T14:08:22Z

Not sure why, but my file changes take like 5 seconds to be detected now, and setting debounce seems to have no affect.

Same thing for me. ~5 seconds to detect any changes.

jaysoo · 2023-07-19T14:10:54Z

@jasonmacdonald @andrey59412678 Can you open a new issue and link to this one? It's different from the scope of this original issue. Since we are just running the build in watch mode now, the changes should be handled by the bundler (e.g. webpack, vite, etc.).

If you have a reprod to link that would help as well.

jasonmacdonald · 2023-07-21T13:17:12Z

@jaysoo I figured my issue out by turning on profile: true in webpack so I could see what was happening. Unfotunately, the lack of any console output during rebuild will lead a lot of people to think something is wrong with NX, when it may actually be a slow build in webpack.

To fix this, I ended up setting progress: true in my serve project which provides a nice little one liner in the console that updates showing the build progress. That helps us to know that something is happening and it's not just hanging. Hope that helps.

"buildTargetOptions": {
         "progress": true
}

jaysoo · 2023-07-27T00:06:28Z

@jaysoo I figured my issue out by turning on profile: true in webpack so I could see what was happening. Unfotunately, the lack of any console output during rebuild will lead a lot of people to think something is wrong with NX, when it may actually be a slow build in webpack.

To fix this, I ended up setting progress: true in my serve project which provides a nice little one liner in the console that updates showing the build progress. That helps us to know that something is happening and it's not just hanging. Hope that helps.
"buildTargetOptions": {
         "progress": true
}

Got it. We'll double-check to make sure progress is on by default, and maybe show a general indicator if possible.

adamwdennis · 2023-08-16T15:37:22Z

FWIW, the following fixed the issue for me when upgrading @nx/js (et. al.) from v16.4.0-beta.5 to v16.7.0:

`project.json` for my nestjs app that uses graphql (the issue was that it emits the schema file after watch is started)

"serve": {
  "options": {
    "runBuildTargetDependencies": true
  },
}

vbuongiovanni · 2023-08-21T19:48:17Z

This is probably obvious.. but for anyone who is incapable of following simple directions (such as myself), I hope this will help:

I was experiencing similar issues with egregious restart times after my team updated NX. After all the proposed fixes mentioned above failed to resolve my issue, I realized that I never ran the following two nx commands -

nx migrate latest
nx migrate --run-migrations

After that, the issues were resolved without any other modifications.

github-actions · 2023-09-21T00:06:39Z

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

pedropmedina added the type: bug label May 17, 2023

AgentEnder added the scope: node Issues related to Node, Express, NestJS support for Nx label May 17, 2023

YeomansIII mentioned this issue Jun 13, 2023

Server restarted by any changes in next-app (don't work Fast Refresh) #17420

Closed

4 tasks

zub0r mentioned this issue Jun 13, 2023

Nestjs serve crash after "File change detected. Restarting..." #17208

Closed

4 tasks

Filoz mentioned this issue Jun 14, 2023

"nx serve" on Windows with node app (framework: none) crashes any time any time a source file is saved: "Command failed: taskkill /pid xxx /T /F | The process "xxx" not found." #17273

Closed

4 tasks

meeroslav added the scope: js label Jun 15, 2023

KeithGillette mentioned this issue Jun 22, 2023

Server Side Rendering Error #17704

Closed

4 tasks

jaysoo reopened this Jul 14, 2023

jaysoo mentioned this issue Jul 17, 2023

fix(js): run build in watch mode when specified for faster recompile time #18145

Merged

jaysoo closed this as completed in #18145 Jul 17, 2023

andrey59412678 mentioned this issue Aug 6, 2023

fix(webpack): enable in memory caching when building for node in watch mode #18348

Merged

github-actions bot added the outdated label Sep 21, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023

> NX File change detected. Restarting... #17070

> NX File change detected. Restarting... #17070

Comments

pedropmedina commented May 17, 2023

Current Behavior

Expected Behavior

GitHub Repo

Steps to Reproduce

Nx Report

Failure Logs

Operating System

Additional Information

salihsagdilek commented May 17, 2023 • edited

thenglong commented May 18, 2023 • edited

YeomansIII commented May 18, 2023 • edited

YeomansIII commented May 18, 2023 • edited

ibockowsky commented May 25, 2023

thenglong commented May 25, 2023 • edited

PointSingularity commented May 25, 2023 • edited

Tirke commented May 26, 2023

jasonmacdonald commented May 31, 2023

KeithGillette commented Jun 1, 2023 • edited

ibockowsky commented Jun 12, 2023 • edited

jasonmacdonald commented Jun 12, 2023

urugator commented Jun 14, 2023 • edited

ggagosh commented Jun 15, 2023

meeroslav commented Jun 15, 2023

danyhiol commented Jun 19, 2023

pedroqueiroz commented Jun 23, 2023 • edited

bcerquiare commented Jun 23, 2023

KranzAklilu commented Jun 25, 2023 • edited

thenglong commented Jun 25, 2023

codeninja commented Jun 26, 2023 • edited

codeninja commented Jun 26, 2023

PointSingularity commented Jun 30, 2023

jaysoo commented Jul 14, 2023

om-mahato commented Jul 14, 2023

jaysoo commented Jul 14, 2023

KeithGillette commented Jul 14, 2023

jaysoo commented Jul 14, 2023

andrey59412678 commented Jul 14, 2023

stewones commented Jul 15, 2023 • edited

ggagosh commented Jul 17, 2023

Nightbr commented Jul 17, 2023

PointSingularity commented Jul 18, 2023

jasonmacdonald commented Jul 18, 2023

stewones commented Jul 18, 2023

ggagosh commented Jul 18, 2023

kurt-west commented Jul 18, 2023

jaysoo commented Jul 18, 2023

PointSingularity commented Jul 18, 2023

jaysoo commented Jul 18, 2023

andrey59412678 commented Jul 19, 2023

jaysoo commented Jul 19, 2023

jasonmacdonald commented Jul 21, 2023 • edited

jaysoo commented Jul 27, 2023

adamwdennis commented Aug 16, 2023

project.json for my nestjs app that uses graphql (the issue was that it emits the schema file after watch is started)

vbuongiovanni commented Aug 21, 2023

github-actions bot commented Sep 21, 2023

salihsagdilek commented May 17, 2023 •

edited

thenglong commented May 18, 2023 •

edited

YeomansIII commented May 18, 2023 •

edited

YeomansIII commented May 18, 2023 •

edited

thenglong commented May 25, 2023 •

edited

PointSingularity commented May 25, 2023 •

edited

KeithGillette commented Jun 1, 2023 •

edited

ibockowsky commented Jun 12, 2023 •

edited

urugator commented Jun 14, 2023 •

edited

pedroqueiroz commented Jun 23, 2023 •

edited

KranzAklilu commented Jun 25, 2023 •

edited

codeninja commented Jun 26, 2023 •

edited

stewones commented Jul 15, 2023 •

edited

jasonmacdonald commented Jul 21, 2023 •

edited

`project.json` for my nestjs app that uses graphql (the issue was that it emits the schema file after watch is started)