@nrwl/node:execute does not wait for app to stop

[pburgmer]

Expected Behavior

App receives SIGTERM and starts to shut down. Builder will wait for app to shut down and restart after app process has stopped.

Current Behavior

Builder sends SIGTERM to app. App starts to shut down. Builder restarts app before process has stopped.

Failure Information (for bugs)

Inspect-Port is still in use (previous process not killed yet) and therefore app restart fails.

Steps to Reproduce

I created a minimal setup to reproduce the bug. Please see https://github.com/pburgmer/nx-reproduce-restart-to-early

• Create Workspace
• Add Nest Application
• Tell Nest to use shutdown hooks (in main.ts)
• Implement long running shutdown hook (in app.service.ts)
• Run ng serve
• Change some code and save
• Restart fails

Context

Node 12.6.0
MacOS 10.14.6
Nx 8.4.10

Failure Logs

app shutdown started
Starting inspector on localhost:7777 failed: address already in use
app shutdown finished

Other

Problem seems to be in packages/node/src/builders/execute/execute.impl.ts

• function restartProcess calls killProcess
• returned observable emits before process stopped

I guess the problem is tree-kill and not nx itself. But as tree-kill repo is very inactive and I haven't tested tree-kill in isolation, I thought it would be good to addess it here.

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.