Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add generator for converting to flat config #17532

Merged
merged 25 commits into from
Aug 8, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Jun 9, 2023

A new generator to convert workspace from standard lint configs to new flat eslint config.

Based on: typescript-eslint/typescript-eslint#6836
According to: https://eslint.org/blog/2022/08/new-config-system-part-2/
Following: https://eslint.org/docs/latest/use/configure/migration-guide

  • Extend updateProjectConfiguration to update package.json as well
  • Create generator shell with options
  • Add unit tests
  • Implement nx.json conversion
  • Implement project config conversion
  • Convert config to new format
    • Covert ignores
    • Convert extends
    • Convert overrides
    • Convert settings
    • Convert rules
    • Convert parsers
    • Convert plugins
    • Linter Options
    • Predefined and Shareable Configs
    • Language Options
  • Add E2E test
  • Make improvements after sync with ESLint team

@meeroslav meeroslav self-assigned this Jun 9, 2023
@meeroslav meeroslav requested a review from juristr June 9, 2023 20:02
@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 4:21pm

@meeroslav meeroslav marked this pull request as draft June 12, 2023 09:46
@meeroslav meeroslav changed the title feat(linter): add generator for converting to flat config feat(linter): add generator for converting to flat config WIP Jul 18, 2023
@meeroslav meeroslav merged commit b8c3ec4 into nrwl:master Aug 8, 2023
15 checks passed
@meeroslav meeroslav deleted the convert-to-flat-config branch August 8, 2023 18:08
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants