fix(core): normalizing key of patched packages with its actual resolved version and not the one from the key

[veimox]

Current Behavior

As described in #17873

My understanding of the sitatuion is that it is an edge case. The issue can be replicated in the repo from @ganlhi where the following happens:

1. In the package.json there is the definition "typescript": "~5.1.3" but in the lock file it is resolved with 5.1.6
2. When generating the keys for the yarn.lock it uses, not the version from the string defined by the user (5.1.3), but the actual version resolved by yarn (5.1.6)
3. Then we go an prepare the objects to be pruned. For the specific case of the packages that have patch in berry we use its nomalised key to prune the lock file . This normalised key uses the version from the string, and not the resolved from yarn, which then in this bit is trigerred as a deletion because it does not match the version.
4. This effectively deletes the key giving the issue described in Lockfile generated by @nx/next:build is invalid #17873 with an empty "" key for the value of the typescript package. It can seen better in the screenshot

This PR solves the issue but calculating the normalizedKey by using the resolved version of yarn and fixes the issue.

That said, perhaps there is a better way of fixing this because I do not have in-depth knowledge on the matter. Hopefully will give some info to the dev that can fix it 😄

Expected Behavior

It generates a valid yarn.lock

Related Issue(s)

#17873
(Maybe) #17853 done by @meeroslav

Fixes #17873

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2023 1:18pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8404ac4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• linux nx affected --target=e2e --base=999c2b5eeea34bd81158f95fe69551acdee34871 --head=8404ac47b2282ef5c166ba0d5592d366b7bfa59a --parallel=1
• linux nx affected --target=test --base=999c2b5eeea34bd81158f95fe69551acdee34871 --head=8404ac47b2282ef5c166ba0d5592d366b7bfa59a --parallel=1
• linux nx affected --target=build --base=999c2b5eeea34bd81158f95fe69551acdee34871 --head=8404ac47b2282ef5c166ba0d5592d366b7bfa59a --parallel=3
• linux nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• linux nx affected --target=lint --base=999c2b5eeea34bd81158f95fe69551acdee34871 --head=8404ac47b2282ef5c166ba0d5592d366b7bfa59a --parallel=3
• nx-cloud record -- nx format:check --base=999c2b5eeea34bd81158f95fe69551acdee34871 --head=8404ac47b2282ef5c166ba0d5592d366b7bfa59a
• linux nx documentation --no-dte
• macos nx affected -t e2e-macos --parallel=1 --base=999c2b5eeea34bd81158f95fe69551acdee34871 --head=8404ac47b2282ef5c166ba0d5592d366b7bfa59a

---

Sent with 💌 from NxCloud.

[veimox]

@meeroslav @AgentEnder any feedback on this PR or the blocking issue?

[meeroslav]

Sorry for waiting. I will look into it as soon as possible.

[meeroslav]

Thank you for this PR!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.