Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): check if target exists before adding target for jest #18327

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

jest generator assumes there will be a target object when adding test target

Expected Behavior

jest generator defaults targets object before adding test target if it does not exist

Related Issue(s)

Fixes #17776

@barbados-clemens barbados-clemens requested a review from a team as a code owner July 26, 2023 16:16
@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 7:24pm

@barbados-clemens barbados-clemens self-assigned this Jul 26, 2023
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Jul 26, 2023
@barbados-clemens barbados-clemens changed the title fix(testing): default targets if does not exist fix(testing): check if target exists before adding target for jest Jul 26, 2023
@barbados-clemens barbados-clemens enabled auto-merge (squash) July 26, 2023 16:33
@barbados-clemens barbados-clemens merged commit 697754d into nrwl:master Aug 2, 2023
15 checks passed
@barbados-clemens barbados-clemens deleted the fix/testing-target branch August 2, 2023 13:56
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong hint about --dry-run
2 participants