Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update e2e tsconfig extends to be mapped to the correct root tsconfig #18408

Merged

Conversation

ndcunningham
Copy link
Contributor

What has changed:

  • When we update non root projects ensures that the tsconfig extends to the tsconfig.base.json

@ndcunningham ndcunningham requested a review from a team as a code owner July 31, 2023 19:19
@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 6:15pm

@FrozenPandaz FrozenPandaz merged commit 3ae657c into nrwl:master Aug 1, 2023
15 checks passed
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
@ndcunningham ndcunningham deleted the fix/convert-to-monorepo-e2e-tsconfig branch August 21, 2023 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants