Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): respect cwd when adding node_modules/.bin to PATH in run-commands #18429

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

jonathanmorley
Copy link
Contributor

Provide the cwd to the npm-run-path library so that the PATH additions include the cwd

closed #18428

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Provide the cwd to the npm-run-path library so that the PATH additions include the cwd

closed nrwl#18428
@jonathanmorley jonathanmorley requested a review from a team as a code owner August 1, 2023 20:30
@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 8:33pm

@AgentEnder AgentEnder changed the title fix(core): respect cwd when adding node_modules/.bin to PATH fix(misc): respect cwd when adding node_modules/.bin to PATH in run-commands Aug 11, 2023
@AgentEnder AgentEnder merged commit eafc8af into nrwl:master Aug 11, 2023
15 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The run-commands executor doesn't respect provided cwd when adding node_modules binaries
2 participants