Creating an angular workspace with appName='app' breaks angular.json

[IgorAufricht]

Expected Behavior

I should be able to create a workspace with an angular app named "app".

Current Behavior

The workspace gets created, but the angular.json file gets incorrectly modified.

Steps to Reproduce

1. Run npx create-nx-workspace@8.5.0 nxrepo --preset=angular --cli=angular
2. Use "app" as the "Application name"
3. Run ng build

This will fail with:

Schema validation failed with the following errors:
  Data path ".projects['app'].projectType" should be equal to one of the allowed values.

This is because the angular.json file now contains the following:

{
  "version": 1,
  "projects": {
    "app": {
      "projectType": "apps/application",   // <- this
      "schematics": {},
      ...

Other

For what it's worth, I tracked it to the replaceAppNameWithPath function.

[jdpearce]

Thanks for raising this issue, @IgorAufricht! I think you and I must have found this problem at the same time.

This seems to occur with any application with a name that is contained within the word "application". The same bug will also cause problems for anyone trying to add a library with a name like "lib".

Thanks for tracking down the relevant bit of code!

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.