feat(core): update dotenv and load root env variables earlier #18456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
changed the title
FrozenPandaz
approved these changes
Aug 9, 2023
| @@ -318,11 +316,17 @@ export class ForkedProcessTaskRunner { | |||
| outputPath: string, | |||
| streamOutput: boolean | |||
| ) { | |||
| // Unload any dot env files at the root of the workspace that were loaded on init of Nx. | |||
| this.unloadDotEnvFiles(process.env); | |||
There was a problem hiding this comment.
This shouldn't unload it from the actual process.env
| @@ -26,6 +27,8 @@ function main() { | |||
| assertSupportedPlatform(); | |||
| } | |||
|
|
|||
| loadDotEnvFiles(); | |||
There was a problem hiding this comment.
Can we add a performance timing here?
AgentEnder
approved these changes
Aug 9, 2023
AgentEnder
changed the title
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We currently don't attempt to load dotenv files until the forked process task runner begins to run a task.
There are other Nx Commands that may benefit from the values stored in workspace root dotenv files.
Expected Behavior
Load the workspace root dotenv files during invocation of nx.
Ensure the order that dotenv files are loaded for task remains correct.
Related Issue(s)
Fixes #17634