Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): cleanup e2e cache on global setup #18483

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav requested a review from a team as a code owner August 4, 2023 09:42
@meeroslav meeroslav self-assigned this Aug 4, 2023
@meeroslav meeroslav requested review from vsavkin, mandarini and a team as code owners August 4, 2023 09:42
@vercel
Copy link

vercel bot commented Aug 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2023 9:47am

process.env.NX_E2E_SKIP_BUILD_CLEANUP !== 'true' ||
!existsSync('./build')
) {
if (process.env.NX_E2E_SKIP_CLEANUP !== 'true' || !existsSync('./build')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The env variable in the .github files was renamed, but this one isn't. Should it be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are all renamed.

@meeroslav meeroslav merged commit 0429536 into nrwl:master Aug 8, 2023
15 checks passed
@meeroslav meeroslav deleted the remove-e2e-on-global-setup branch August 8, 2023 18:07
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants