fix(core): all graph nodes should have targets block, even if its empty

[AgentEnder]

Current Behavior

After #18032 project nodes on the graph may not have a targets block. We've always supported projects having undefined targets in generators when a project is defined by package.json or similar, but once they are in the graph they have generally had the targets block. This was a result of the mergePluginTargets function which assigned targets from nx plugin's registerProjectTargets method.

In #18032 we removed that method entirely, and didn't notice that it was essentially doing node.data.targets ??= {}.

In our own code, this resulted in nx graph failing when it tried to build the task graphs for the UI to display but it would not be unrealistic to say that there would be other cases that this would crop up in the Nx codebase or user's custom scripts.

Expected Behavior

Project nodes have a targets block, even if it may be empty and all createNodes functions returned undefined targets.

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 14, 2023 6:02pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 75b2877. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• linux nx affected --target=e2e --base=645535be46e9d91f62c9c8857c3474c9babbe1d8 --head=75b2877fd2dc6cdc9a8cbd1b9c7bab4907045d3f --parallel=1
• linux nx affected --target=test --base=645535be46e9d91f62c9c8857c3474c9babbe1d8 --head=75b2877fd2dc6cdc9a8cbd1b9c7bab4907045d3f --parallel=1
• linux nx affected --target=build --base=645535be46e9d91f62c9c8857c3474c9babbe1d8 --head=75b2877fd2dc6cdc9a8cbd1b9c7bab4907045d3f --parallel=3
• linux nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• linux nx affected --target=lint --base=645535be46e9d91f62c9c8857c3474c9babbe1d8 --head=75b2877fd2dc6cdc9a8cbd1b9c7bab4907045d3f --parallel=3
• nx-cloud record -- nx format:check --base=645535be46e9d91f62c9c8857c3474c9babbe1d8 --head=75b2877fd2dc6cdc9a8cbd1b9c7bab4907045d3f
• linux nx documentation --no-dte
• macos nx affected -t e2e-macos --parallel=1 --base=645535be46e9d91f62c9c8857c3474c9babbe1d8 --head=75b2877fd2dc6cdc9a8cbd1b9c7bab4907045d3f

---

Sent with 💌 from NxCloud.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.